GDScript: Reuse scripts from ResourceCache#114623
Closed
HolonProduction wants to merge 1 commit intogodotengine:masterfrom
Closed
GDScript: Reuse scripts from ResourceCache#114623HolonProduction wants to merge 1 commit intogodotengine:masterfrom
ResourceCache#114623HolonProduction wants to merge 1 commit intogodotengine:masterfrom
Conversation
HolonProduction
force-pushed
the
gdscript/inconsistent-is-the-new-consistent
branch
from
140c922 to
85d7907
Compare
adamscott
reviewed
Jan 5, 2026
Member
|
The GDScript test suite seems to crash. |
Member
Author
|
Yeah my bad 🤦 This probably wont work without major hacks, because the edge-case does not only remove the script from the cache but also destructs all of its members. So the script in the |
HolonProduction
force-pushed
the
gdscript/inconsistent-is-the-new-consistent
branch
from
85d7907 to
79149da
Compare
HolonProduction
force-pushed
the
gdscript/inconsistent-is-the-new-consistent
branch
from
79149da to
b4bc2e2
Compare
5 tasks
Member
Author
|
Superseded by #114651 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #114420
Fixes #98141 (tested using the 4.3 MRP by myself. Not the original one.)
This code originally assumed that if a script object was present for a certain path it would be in either
GDScriptCache::shallow_gdscript_cacheorGDScriptCache::full_gdscript_cache. However in the linked issues an edge case occurs, were the script object is not in them anymore. This PR also looks into theResourceCacheto handle that edge case correctly.Idk whether the edge case occurring in the first place is also a bug. But this is the least invasive fix I could think of without opening the whole cyclic ref topic.